-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Performance improvements in Buttons, Image and SocialLinks related controls #28238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
6edd623
to
c5372f0
Compare
Size Change: +2.54 kB (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
dratwas
requested changes
Jan 25, 2021
packages/block-library/src/buttons/content-justification-dropdown.js
Outdated
Show resolved
Hide resolved
packages/components/src/mobile/cycle-select-control/index.native.js
Outdated
Show resolved
Hide resolved
packages/components/src/mobile/link-settings/link-settings-navigation.native.js
Outdated
Show resolved
Hide resolved
dratwas
requested changes
Feb 4, 2021
packages/components/src/mobile/link-settings/link-settings-screen.native.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Drapich Piotr <[email protected]>
dratwas
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
[Type] Performance
Related to performance efforts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after
Cover
PR: #28235Description
Part of: #28196
Contains changes only related to the
Image
,Button
andSocialLinks
blocks and controls available within block settings and inherit changes fromCover
PR.These 3 blocks are grouped in one PR since using the same control called
LinkSettings
where previously passedattributes
object is replaced in favour of passing separate attributes.BlockStyles
CycleSelectControl
TextControl
FooterMessageControl
LinkSettings
TextControl
TextControl
ToggleControl
TextControl
FooterMessageControl
PanelActions
ColorEdit
RangeControl
LinkSettings
TextControl
TextControl
ToggleControl
TextControl
FooterMessageControl
PanelActions
LinkSettings
TextControl
TextControl
How has this been tested?
Do sanity testing for
Image
,Button
andSocialIcons
blocks using instructions from test casesScreenshots
RESULTS
1. Image - change image style
2. Image - change image size
3. Image - add character in
alt
4. Buttons - change radius
5. Social Icons - add character in label
Types of changes
Performance improvements
Checklist: